Skip to content

feat(remix): Support defer() usage in rootAuthLoader() - #1926

Merged
brkalow merged 4 commits into
mainfrom
brk.feat/remix-defer-support
Oct 23, 2023
Merged

feat(remix): Support defer() usage in rootAuthLoader()#1926
brkalow merged 4 commits into
mainfrom
brk.feat/remix-defer-support

Conversation

@brkalow

@brkalow brkalow commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Add logic to support defer() usage in the wrapped loader. Currently, this isn't handled and we end up dropping the return value.

Note
I'm working on some integration tests for this locally, they will come in a followup.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@changeset-bot

changeset-bot Bot commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 62b8c24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/remix Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brkalow

brkalow commented Oct 20, 2023

Copy link
Copy Markdown
Member Author

!snapshot

@clerk-cookie

clerk-cookie commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

Hey @brkalow - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 0.31.3-snapshot.v5e874e4
@clerk/chrome-extension 0.4.10-snapshot.v5e874e4
@clerk/clerk-js 4.62.2-snapshot.v5e874e4
@clerk/clerk-expo 0.19.12-snapshot.v5e874e4
@clerk/fastify 0.6.17-snapshot.v5e874e4
gatsby-plugin-clerk 4.4.18-snapshot.v5e874e4
@clerk/localizations 1.26.7-snapshot.v5e874e4
@clerk/nextjs 4.25.7-snapshot.v5e874e4
@clerk/clerk-react 4.26.7-snapshot.v5e874e4
@clerk/remix 3.1.0-snapshot.v5e874e4
@clerk/clerk-sdk-node 4.12.16-snapshot.v5e874e4
@clerk/shared 1.0.0-snapshot.v5e874e4
@clerk/themes 1.7.9-snapshot.v5e874e4
@clerk/types 3.56.2-snapshot.v5e874e4

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@0.31.3-snapshot.v5e874e4 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@0.4.10-snapshot.v5e874e4 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@4.62.2-snapshot.v5e874e4 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@0.19.12-snapshot.v5e874e4 --save-exact

@clerk/fastify

npm i @clerk/fastify@0.6.17-snapshot.v5e874e4 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@4.4.18-snapshot.v5e874e4 --save-exact

@clerk/localizations

npm i @clerk/localizations@1.26.7-snapshot.v5e874e4 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@4.25.7-snapshot.v5e874e4 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@4.26.7-snapshot.v5e874e4 --save-exact

@clerk/remix

npm i @clerk/remix@3.1.0-snapshot.v5e874e4 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@4.12.16-snapshot.v5e874e4 --save-exact

@clerk/shared

npm i @clerk/shared@1.0.0-snapshot.v5e874e4 --save-exact

@clerk/themes

npm i @clerk/themes@1.7.9-snapshot.v5e874e4 --save-exact

@clerk/types

npm i @clerk/types@3.56.2-snapshot.v5e874e4 --save-exact

brkalow
brkalow commented Oct 20, 2023
View reviewed changes
Comment thread playground/remix-node/app/root.tsx Outdated
@brkalow
brkalow requested a review from a team October 20, 2023 22:25
@brkalow
brkalow added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 37ad032 Oct 23, 2023
@brkalow
brkalow deleted the brk.feat/remix-defer-support branch October 23, 2023 22:55
@clerk-cookie clerk-cookie mentioned this pull request Oct 23, 2023
Merged
@clerk-cookie

clerk-cookie commented Oct 23, 2024

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tmilewski tmilewski tmilewski approved these changes

Assignees

No one assigned

Labels

playground remix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brkalow @clerk-cookie @tmilewski